search

promises-aplus / promises-spec

An open standard for sound, interoperable JavaScript promises—by implementers, for implementers.
https://promisesaplus.com/
Creative Commons Zero v1.0 Universal
1.84k stars 171 forks source link

adding welsh #203

Closed kode4food closed 8 years ago

bergus commented 8 years ago

What exactly does "but not really" refer to?

kode4food commented 8 years ago

It refers to the Deferreds impl that is bundled along with the A+ Promises -- they were originally the only thing I included when I started the project a few days ago.

But does it matter? The promises impl passes the suite, which is the only qualification as far as the list and logo are concerned

briancavalier commented 8 years ago

Thanks @kode4food.

But does it matter?

I think @bergus was just curious--the phrase caught my attention, too, to be honest. Yes, you're right, as long as it passes the tests, you're good. I'll give it a go later tonight.

kode4food commented 8 years ago

Fair enough. The ultimate goal of the library is to create semi-interchangeable Twisted-like Deferreds and Promises, so I didn't want to push the idea that this was only a A+ Promises impl.

kode4food commented 8 years ago

to test, you can either do npm run-script compliance or just run the gulp build script since I'm sucking the mocha tests into my own

briancavalier commented 8 years ago

Got it, thanks. And thanks for the instructions on running the tests.

briancavalier commented 8 years ago

Yep, all tests pass. Good job, @kode4food.

kode4food commented 8 years ago

fantastic, thanks!