promises-aplus / promises-spec

An open standard for sound, interoperable JavaScript promises—by implementers, for implementers.
https://promisesaplus.com/
Creative Commons Zero v1.0 Universal
1.84k stars 164 forks source link

Add Hprose to the implementations list. #206

Closed andot closed 9 years ago

andot commented 9 years ago
var hprose = require("hprose");
var promisesAplusTests = require("promises-aplus-tests");

promisesAplusTests(hprose, function (err) {
    // All done; output is in the console. Or check `err` for number of failures.
});

It can pass all tests.

bergus commented 9 years ago

Hi, could you please squash these commits into a single one? Also I'm not sure wether this lib needs two entries in the frameworks table; the promise implementation does not seem to differ between them except for the used module definition pattern.

andot commented 9 years ago

OK, I removed the hprose for html5, only left hprose for node.js.

briancavalier commented 9 years ago

@andot Good job, tests pass. One suggestion: I think it would be helpful if you would list promises-plus-tests as a devDependency in package.json, and also provide a convenient way to run them, such as adding an npm script, like npm run aplus-tests.

Also, as @bergus asked, please squash to a single commit.

andot commented 9 years ago

OK, I added npm run aplus-tests and squashed to a single commit, now.

domenic commented 9 years ago

Hmm, trying to do npm install after cloning https://github.com/hprose/hprose-nodejs gives the following error:

npm ERR! 404 Registry returned 404 for GET on https://registry.npmjs.org/promises-plus-tests

Looks like a typo in the package.json?

andot commented 9 years ago

Fixed this bug.

domenic commented 9 years ago

Merged as 3c76b7fed3a1c451d47f2f8eef8d58aa385e678d; thank you!