Open joouha opened 1 year ago
I don't think the test failures are related to the proposed changes
I've rebased and fixed the issues with checks.
This would also allow implementing a wrapping Container
which can automatically disable mouse support for an app if you've scrolled to the top, allowing the terminal scrollback buffer to be scrolled instead.
These changes mean that Windows will return
NotImplemented
when attempting to scroll beyond their scrollable limits.This means mouse scroll events can bubble up to a scrollable parent container when a window has finished scrolling.
In the following screen recording, you can see that when the
TextArea
moves under the mouse while scrolling the parent pane, it begins scrolling, and when theTextArea
has scrolled all the way to the bottom, the parent pane resumes scrolling:nested-scrolling.webm
I've also changed the reported line-count of the
DummyControl
to1
rather than100*100
for this to work. Without this, Windows without content believe theirDummyControl
is always scrollable and accept all scroll events. I can't find any issues with doing this - why was theDummyControl
's content's line count set to100*100
?