search

prompt-toolkit / python-prompt-toolkit

Library for building powerful interactive command line applications in Python
https://python-prompt-toolkit.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
9.11k stars 718 forks source link

1729 fix filter caching regression #1730

Closed jonathanslenders closed 1 year ago

Carreau commented 1 year ago

Yep, that fixes, #1729 

$ git checkout 75ecfe932fc9ca3505efbebc016b046ffc7d0d68
$ pytest IPython/terminal/tests/test_shortcuts.py::test_modify_shortcut_with_filters
IPython/terminal/tests/test_shortcuts.py .            [100%]

And main just before this PR fails.

Thanks ! (I'll just pin IPython to != 3.0.37 for next release)

Carreau commented 1 year ago

Thanks !

jonathanslenders commented 1 year ago

@Carreau : I released 3.0.38 which includes this fix.

Carreau commented 1 year ago

Thanks !

On Tue, 28 Feb 2023 at 10:58, Jonathan Slenders @.***> wrote:

@Carreau https://github.com/Carreau : I released 3.0.38 which includes this fix.

— Reply to this email directly, view it on GitHub https://github.com/prompt-toolkit/python-prompt-toolkit/pull/1730#issuecomment-1447889193, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACR5TZYJD7YEQOFGKCNRJLWZXD6DANCNFSM6AAAAAAVJ4KKUY . You are receiving this because you were mentioned.Message ID: @.***>