prompt-toolkit / python-prompt-toolkit

Library for building powerful interactive command line applications in Python
https://python-prompt-toolkit.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
9.11k stars 717 forks source link

Add support for Python 3.12 #1782

Closed hugovk closed 8 months ago

hugovk commented 9 months ago

The second Python 3.12 release candidate is out! :rocket:

Call to action

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.12 compatibilities during this phase, and where necessary publish Python 3.12 wheels on PyPI to be ready for the final release of 3.12.0.

See also https://dev.to/hugovk/help-test-python-312-beta-1508/


Python 3.7 is EOL and no longer receiving security updates (or any updates) from the core Python team.

version released eol
3.11 2022-10-24 2027-10-24
3.10 2021-10-04 2026-10-04
3.9 2020-10-05 2025-10-05
3.8 2019-10-14 2024-10-14
3.7 2018-06-26 2023-06-27

https://devguide.python.org/versions/


Also upgraded Python syntax with https://github.com/asottile/pyupgrade --py38-plus.

doronz88 commented 8 months ago

Do you know if this PR is expected to be merged? or if this python project is even still maintained?

hugovk commented 8 months ago

I expect it will at some point, and the project had a release on July so looks maintained.

And I think you can use this project on 3.12 fine without this PR.

jonathanslenders commented 8 months ago

Sorry, I don't want to drop Python 3.7 support yet, and 3.12 should already be supported. We might want to add 3.12 to the pipeline though.

@doronz88 : This project is definitely still maintained, but that doesn't mean there's activity every day.

hugovk commented 8 months ago

Sure, I've removed the commits dropping 3.7.

jonathanslenders commented 8 months ago

Hi @hugovk : Would you be able to rebase on master? I applied some changes because of Ruff, and because of that, some changes here are not relevant anymore.

jonathanslenders commented 8 months ago

Thanks!

hugovk commented 8 months ago

You're welcome!