search

prompt-toolkit / python-prompt-toolkit

Library for building powerful interactive command line applications in Python
https://python-prompt-toolkit.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
9.1k stars 717 forks source link

Expand type definition for filename #1849

Closed alexrudd2 closed 4 months ago

alexrudd2 commented 4 months ago

FileHistory.filename is currently hinted as str.

It is used by open() and os.path.exists(). os.path.exists() supports os.PathLike since 3.6

Therefore, the type hint should be expanded to Union[str, os.PathLike].

jonathanslenders commented 4 months ago

Thanks!