prompt-toolkit / pyvim

Pure Python Vim clone.
BSD 3-Clause "New" or "Revised" License
2.52k stars 161 forks source link

Implement file explorer #100

Closed davidbrochart closed 5 years ago

davidbrochart commented 6 years ago

When opening a directory, the file or directory under the cursor can be opened by pressing Enter. I used a file_explorer attribute for each editor_buffer, and for the editor, which is synced with the current buffer. When the file_explorer attribute is not empty, it means that we are in "file explorer mode" and its content is the path of the directory we are in.

jonathanslenders commented 6 years ago

Thank you @davidbrochart, This looks very nice! I'll merge it later when I have some time to review it.

Also, pyvim didn't got a lot of attention lately. Which is because I've been focussing mostly on prompt_toolkit 2.0. When that's released I'd like to make sure that pyvim runs on 2.0 as well, which should solve a couple of pyvim issues.

davidbrochart commented 6 years ago

Hi @jonathanslenders, this feature is quite handy. Any chance you can merge it?

jonathanslenders commented 5 years ago

Hi @davidbrochart, this took me way too long, but finally I've merged it here: https://github.com/jonathanslenders/pyvim/commit/a511949ff13bffcef64e5421e7a939e997efb1b9 I had to do a couple of modifications due to some changes to prompt_toolkit 2.0 that we had in the meantime.

davidbrochart commented 5 years ago

Thanks!