search

prompt-toolkit / pyvim

Pure Python Vim clone.
BSD 3-Clause "New" or "Revised" License
2.52k stars 161 forks source link

zt and zb not working #65

Closed rgkirch closed 8 years ago

rgkirch commented 8 years ago

I don't know if these controls are not supposed to work but as 'zz' works it seems incomplete to leave out 'zt' and 'zb'. Does this work for you? Is it actually a bug?

amjith commented 8 years ago

Looks like zt is the same as z<cr> and zb is the same as z- which is already implemented. So it should be easy to add them.

rgkirch commented 8 years ago

Aha, I didn't know about those until now. Then zt should be mapped to what z<cr> does but z<cr> needs to be modified a little so that the cursor resets to the first column after scrolling. Similarly zb should be mapped to what z- does and z- should be modified. Thanks for teaching me more short-cuts.

jonathanslenders commented 8 years ago

That pull request of @amjith has been merged, so the next pyvim release will include it. Thanks everyone!