pronamic / memberpress

MemberPress, Git-ified. This repository is just a mirror of the MemberPress plugin. Please do not send pull requests.
https://memberpress.com/change-log/
GNU General Public License v2.0
10 stars 3 forks source link

MemberPress does nothing with the gateway `create-subscriptions` capability #2

Open remcotolsma opened 1 year ago

remcotolsma commented 1 year ago

The default MemberPress gateways all have the create-subscriptions capability:

https://github.com/pronamic/memberpress/search?q=create-subscriptions

That is why we also have this in the Pronamic Pay MemberPress Add-On:

https://github.com/pronamic/wp-pronamic-pay-memberpress/blob/a9ed77a71e2c64ab14e744461661aba8ee08a121/src/Gateways/Gateway.php#L99-L118

You would expect MemberPress to also do something for gateways that don't have the create-subscriptions capability, but unfortunately that is not the case.

rvdsteege commented 1 year ago

Posted by @remcotolsma in https://github.com/pronamic/wp-pronamic-pay-memberpress/issues/12#issuecomment-1597238791:

I think this is MemberPress territory and we have the next MemberPress issue open for that (not yet reported to MemberPress itself as far as I know):

https://github.com/pronamic/memberpress/issues/2

What exactly do we want to report / expect if create-subscriptions is not supported by a payment gateway?

Draft support message Hi, We noticed you're setting the `create-subscriptions` capability in all payment gateways, however this capability seems not be used anywhere. What is it used for? Background: a user of our Pronamic Pay plugin asked us to add support for a specific payment method. The payment method does not support recurring payments, so we don't set the `create-subscriptions` capability. However, the method can still be used for recurring memberships now, which results in a gateway error. Best regards, Pronamic