Don't load admin scripts and styles on theme.php pages unless orbis theme is active

pronamic / wp-orbis

Orbis is a powerful, extendable plugin to boost up your business. Project Management, Customer Relation Management & More…

http://www.pronamic.eu/plugins/orbis/

11 stars 2 forks source link

Don't load admin scripts and styles on theme.php pages unless orbis theme is active #8

Closed lots0logs closed 10 years ago

lots0logs commented 10 years ago

I am planning to use Orbis with a theme made by the company I work for. I noticed that the plugin loads admin scripts and styles that break the theme's layout for its settings panel (which is accessed via themes.php&page=)

remcotolsma commented 10 years ago

Thanks for reporting this issue. We tried to reproduce this issue but don't see any problems. Do you see an error in your webbrowsers developer tools console?

lots0logs commented 10 years ago

When I access mysite.com/wp-admin/themes.php?page=ANYPAGE.php the orbis plugin's scripts are being included on the page. Because I am not using the theme you created to go with the plugin, loading those scripts causes issues for my my theme's control panel which is accessed through themes.php. It should be easy to reproduce, just view the page source of one of the pages under the appearance menu and you should see the scripts are loaded. I hope my explanation is not confusing :grimacing:

remcotolsma commented 10 years ago

The Orbis plugin does indeed load some styles/scripts in the WordPress admin panel.

jQuery UI datapicker
Select2
Autocomplete

These scripts are also used on the admin panel, but we agree that it's not needed to load them on all WordPress admin pages, we improved this in https://github.com/pronamic/wp-orbis/commit/7fc09f3553f1c299c7b5d2bfc45abad5b52421a4.

lots0logs commented 10 years ago

Much appreciated :+1: