pronamic / wp-pay-core

Core components for the WordPress payment processing library. This library is used in the WordPress plugin Pronamic Pay: https://www.pronamicpay.com/, but also allows other plugin developers to set up a payment plugin.
https://www.wp-pay.org/
GNU General Public License v3.0
27 stars 3 forks source link

WPML home URL change conflict #121

Closed remcotolsma closed 1 year ago

remcotolsma commented 1 year ago

Approved, but unfortunately these changes do not resolve the permanent notice for users of translation plugins.

Would be nice/better if we just never show the admin notice if \defined( '\ICL_SITEPRESS_VERSION' ).

As far as I'm concerned we'll leave this for now, if users complain about this we can look for a solution. WPML has already been described as a plugin with conflicts.

Originally posted by @remcotolsma in https://github.com/pronamic/wp-pay-core/issues/106#issuecomment-1459695274

We have a user complaining about this: https://secure.helpscout.net/conversation/2253726512/25688?folderId=1425710