search

pronamic / wp-pay-core

Core components for the WordPress payment processing library. This library is used in the WordPress plugin Pronamic Pay: https://www.pronamicpay.com/, but also allows other plugin developers to set up a payment plugin.
https://www.wp-pay.org/
GNU General Public License v3.0
27 stars 3 forks source link

Remove `plugin_locale` filter for `nl_NL_formal` and `nl_BE` #125

Closed remcotolsma closed 1 year ago

remcotolsma commented 1 year ago

If desired we could copy https://github.com/pronamic/wp-pronamic-pay/blob/main/languages/pronamic-ideal-nl_NL.po to:

  • pronamic-ideal-nl_NL_formal.php
  • pronamic-ideal-nl_BE.php

@rvdsteege Should we do this? Or leave the translation of these locales to https://translate.wordpress.org/projects/wp-plugins/pronamic-ideal/?

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.01 :tada:

Comparison is base (b20133e) 20.40% compared to head (5a0064d) 20.42%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #125 +/- ## ============================================ + Coverage 20.40% 20.42% +0.01% + Complexity 2702 2698 -4 ============================================ Files 113 113 Lines 10850 10841 -9 ============================================ Hits 2214 2214 + Misses 8636 8627 -9 ``` | [Impacted Files](https://app.codecov.io/gh/pronamic/wp-pay-core/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pronamic) | Coverage Δ | | |---|---|---| | [src/Plugin.php](https://app.codecov.io/gh/pronamic/wp-pay-core/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pronamic#diff-c3JjL1BsdWdpbi5waHA=) | `19.03% <ø> (+0.38%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.