search

pronamic / wp-pay-core

Core components for the WordPress payment processing library. This library is used in the WordPress plugin Pronamic Pay: https://www.pronamicpay.com/, but also allows other plugin developers to set up a payment plugin.
https://www.wp-pay.org/
GNU General Public License v3.0
27 stars 3 forks source link

123 core library should no longer load mo file into text domain #126

Closed remcotolsma closed 1 year ago

remcotolsma commented 1 year ago

I find it a pity that some texts will not be translated anymore in all cases (for example, the subscription payment method update page), while they currently are and we do have the translations. However, loading translation from core is not really nice and I have therefore approved the changes.

I have no problem with this myself, Pronamic Pay should not take on the role of a translation plugin. In https://github.com/pronamic/wp-pay-core/pull/126/commits/b9c0cb17feb9f7a6737d04fcc891f6d97ccff384 I mentioned the following:

Users who want to use this functionality can use a plugin such as https://wordpress.org/plugins/jsm-user-locale/.

Fortunately, most websites, users and visitors only deal with 1 language.