pronamic / wp-pay-core

Core components for the WordPress payment processing library. This library is used in the WordPress plugin Pronamic Pay: https://www.pronamicpay.com/, but also allows other plugin developers to set up a payment plugin.
https://www.wp-pay.org/
GNU General Public License v3.0
27 stars 3 forks source link

Show subscription payments that are not linked to a period #131

Closed remcotolsma closed 1 year ago

remcotolsma commented 1 year ago

At the moment, payments that are connected to a subscription, but not to a specific subscription period, will not be shown with a subscription. This may, for example, concern a payment of €0.01 for a payment method/mandate change. But also WooCommerce Subscriptions renewal payments are no longer linked to a specific subscription period.

https://github.com/pronamic/wp-pay-core/blob/6308ab6efc6af243fe882a07e5cf4193249984f9/views/meta-box-subscription-payments.php#L22

https://github.com/pronamic/wp-pay-core/blob/6308ab6efc6af243fe882a07e5cf4193249984f9/src/Subscriptions/Subscription.php#L333-L390

These periodless payments should be shown with subscriptions.

  1. Payments without period are not listed in the subscription payments meta box.

Originally posted by @rvdsteege in https://github.com/pronamic/wp-pronamic-pay-woocommerce/pull/40#pullrequestreview-1472037505

A little bit related: