Code not compatible with PHP 7.4

pronamic / wp-pay-core

Core components for the WordPress payment processing library. This library is used in the WordPress plugin Pronamic Pay: https://www.pronamicpay.com/, but also allows other plugin developers to set up a payment plugin.

https://www.wp-pay.org/

GNU General Public License v3.0

27 stars 3 forks source link

Code not compatible with PHP 7.4 #133

Closed knit-pay closed 1 year ago

knit-pay commented 1 year ago

Hello Team

The below code is not compatible with PHP version 7.4. May I raise a pull request to fix it?

https://github.com/pronamic/wp-pay-core/blob/b55dff3f073c56f5780522a78f6412823b519e7a/views/meta-box-gateway-settings.php#L80

rvdsteege commented 1 year ago

Polyfills for str_starts_with() and str_ends_with() have been included in WordPress since WordPress version 5.9. Therefore, we also mention in our plugin file that WordPress 5.9+ is required:

https://github.com/pronamic/wp-pronamic-pay/blob/d110fb2ca595c1e743ba3c9aa57e193a5e9ddd98/pronamic-ideal.php#L8.

I don't think there's any need to otherwise update the code.