pronamic / wp-pay-core

Core components for the WordPress payment processing library. This library is used in the WordPress plugin Pronamic Pay: https://www.pronamicpay.com/, but also allows other plugin developers to set up a payment plugin.
https://www.wp-pay.org/
GNU General Public License v3.0
27 stars 3 forks source link

Please use wp_enqueue commands #142

Closed remcotolsma closed 1 year ago

remcotolsma commented 1 year ago

From the WordPress.org plugin review team:

Your plugin is not correctly including JS and/or CSS. You should be using the built in functions for this:

And remember you can use this function to add inline javascript:

As of WordPress 5.7, you can pass attributes like async, nonce, and type by using new functions and filters:

If you're trying to enqueue on the admin pages you'll want to use the admin enqueues

Example(s) from your plugin:

pronamic-pay-with-mollie-for-woocommerce/packages/wp-pay/core/src/Core/Gateway.php:349:
$html .= '<script type="text/javascript">document.pronamic_ideal_form.submit();</script>';
pronamic-pay-with-mollie-for-woocommerce/packages/wp-pay/core/views/meta-box-gateway-test.php:207:
<script type="text/javascript">
pronamic-pay-with-mollie-for-woocommerce/packages/wp-pay/core/views/meta-box-gateway-test.php:341:<script type="text/javascript">
pronamic-pay-with-mollie-for-woocommerce/packages/wp-pay/core/views/subscription-mandate.php:269:
<script type="text/javascript">
remcotolsma commented 1 year ago

Fixed in https://github.com/pronamic/wp-pay-core/commit/ec3a7ae3be45fdd3310a447a3baf78a617dd1d1f and https://github.com/pronamic/wp-pay-core/commit/8254498ad123986810d4ec23ba44c4c28ec6cf2d.