Closed remcotolsma closed 10 months ago
Attention: 137 lines
in your changes are missing coverage. Please review.
Comparison is base (
2378651
) 22.38% compared to head (683bfb7
) 22.13%. Report is 13 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I still have to check payments and subscriptions posts with WordPress post status
draft
ortrash
.
Just tested this, seems ok.
This PR may solve this issue:
It also improves/removes these comments:
https://github.com/pronamic/wp-pay-core/blob/68e947335aaf02544109862c4f3c685bfa8df9a9/src/Payments/PaymentsDataStoreCPT.php#L276-L295
https://github.com/pronamic/wp-pay-core/blob/68e947335aaf02544109862c4f3c685bfa8df9a9/src/Subscriptions/SubscriptionsDataStoreCPT.php#L301-L319
And it removes some admin controller code from the data store classes:
https://github.com/pronamic/wp-pay-core/blob/68e947335aaf02544109862c4f3c685bfa8df9a9/src/Payments/PaymentsDataStoreCPT.php#L199-L219
https://github.com/pronamic/wp-pay-core/blob/68e947335aaf02544109862c4f3c685bfa8df9a9/src/Subscriptions/SubscriptionsDataStoreCPT.php#L200-L255
I still have to check payments and subscriptions posts with WordPress post status
draft
ortrash
.