search

pronamic / wp-pay-core

Core components for the WordPress payment processing library. This library is used in the WordPress plugin Pronamic Pay: https://www.pronamicpay.com/, but also allows other plugin developers to set up a payment plugin.
https://www.wp-pay.org/
GNU General Public License v3.0
27 stars 3 forks source link

Always show "Disable Recurring Payments", not just in "Debug Mode" #165

Closed remcotolsma closed 3 weeks ago

remcotolsma commented 8 months ago

Today I had to alert a customer to this setting, and I noticed that we only show this setting in debug mode.

Internal HelpScout ticket: https://secure.helpscout.net/conversation/2454026625/26654?viewId=1425710

https://github.com/pronamic/wp-pay-core/blob/c743a1506d01274286f51d23debf765004b17d6f/src/Admin/AdminSettings.php#L111-L125

The customer gave feedback that this is 'strange':

had de optie Disable starting recurring payments at gateway ook niet gezien want eerst moet je de debug mode inschakelen om dit te kunnen zien, dat vind ik vreemd.

I agree with that, should we always show this option? How do you see this @rvdsteege?

rvdsteege commented 8 months ago

I agree that the option is not very visible (has bothered me too). To always show the 'Disable recurring payments' option could be an improvement, especially if the site has been cloned by the same person who has initially activated Pronamic Pay and therefore might have been on the plugin settings page before. For other cases, I think it will still be too late at the time the setting is discovered in the plugin settings. A better solution would be to make users aware of the setting on URL changes, as suggested in https://github.com/pronamic/wp-pay-core/issues/102.

Part of the underlying issue could also be that users do not always know/realise that recurring payments are started from within the site itself and not by the gateway. But it shouldn't make a difference where payments are started, so we don't have to make that more clear as far as I'm concerned.