Update meta-box-subscription-info.php

[remcotolsma]

• https://github.com/pronamic/pronamic-pay/issues/99#event-12998555481

[remcotolsma]

Did some small improvements in ca1f78151a4342267a80d8e5ed486417c6c47917.

4 times the word "links" in titles

Is that a problem?

all descriptions start with the phrase "This link can be shared with the customer", which also happens to be the same text as the "Action links" help tooltip

Is that a problem?

right alignment of the button makes the button jump when "Copied!" disappears again

Improved in ca1f78151a4342267a80d8e5ed486417c6c47917.

URLs can be quite long, resulting in multiple lines, can we maybe truncate them someway without ending up with three equal URLs from the start of the URLs (e.g. all https://pay.test/?subscription=43653&key=sub...)?

Not easy?

• https://github.com/w3c/csswg-drafts/issues/3937

Would a single description for all actions with clear titles not work, too?

It is a pity that the explanation per link is lost, this one in particular may be valuable:

This link can be shared with the customer and gives the customer the opportunity to change the payment method. This is useful if a credit card expires or if a customer wants to have the charge debited from another account.

[rvdsteege]

4 times the word "links" in titles

Is that a problem?

I wouldn't call it a "problem", but it looks a bit odd and I think that the title on the left side and blue underlining already make it clear enough that these are "links".

all descriptions start with the phrase "This link can be shared with the customer", which also happens to be the same text as the "Action links" help tooltip

Is that a problem?

Yes, repetitive text makes it harder to differentiate between the purposes of the links when scanning the descriptions.

URLs can be quite long, resulting in multiple lines, can we maybe truncate them someway without ending up with three equal URLs from the start of the URLs (e.g. all https://pay.test/?subscription=43653&key=sub...)?

Not easy?

Maybe server-side then? (I can't imagine anyone ever going to select the URL to copy it, instead of copying via the context menu or copy button)

$url = 'https://www.example.com/?subscription=43653&key=subscr_663b8737108d0&action=cancel';

echo \sprintf(
    '%s...%s',
    \substr( $url, 0, 32 ),
    \substr( $url, -24 )
);

// https://www.example.com/?subscri...b8737108d0&action=cancel

It is a pity that the explanation per link is lost, this one in particular may be valuable:

This link can be shared with the customer and gives the customer the opportunity to change the payment method. This is useful if a credit card expires or if a customer wants to have the charge debited from another account.

Therefore I added "update" to the title, as users might not think of updating an expired card or current account as "changing" the payment method. But we could leave the last emphasised part to clarify these specific use cases? Moving the description before the link looks a bit more balanced IMO (especially now that there's more whitespace next to the copy button on its own line).

[kjtolsma]

This implementation makes it a quite massive block. I don't think it needs that much attention. Some additional suggesties.

• Use tooltips for the descriptions?
• "Copy URL to clipboard" is ok but if i see this i think an icon would be a better choice.

URLs can be quite long, resulting in multiple lines, can we maybe truncate them someway without ending up with three equal URLs from the start of the URLs (e.g. all https://pay.test/?subscription=43653&key=sub...)?

Maybe use an input field after all? It will solve this issue and makes more sense in my opinion.

https://github.com/pronamic/pronamic-pay/issues/99

[remcotolsma]

Did some adjustments in 9a9a6def89ae15945500d9e87dbef966738df485.

---

I got inspiration from Woo Subscriptions:

---

Maybe use an input field after all? It will solve this issue and makes more sense in my opinion.

I have already given reasons why I don't think this is ideal. Have you already considered that? Perhaps my objections can be resolved by adding a 'View page' button in addition to a copy button? Does that perhaps give us the best of both?

[kjtolsma]

I got inspiration from Woo Subscriptions:

I don't know if this is the best inspiration. It is a bit of confusing link. I already created an issue for that: https://github.com/pronamic/pronamic-pay/issues/97. We are now introducing the same issue here 😉.

I think this is much better:

But still not sure about the "View page" button. The primary task of the element is "Sharing the action links" with the customer. The copy button adds value for that. I don't think the "View page" button does. You can simply copy past the URL the browser to view the link if you want. Keep things clean and lean. Just my opinion.

[remcotolsma]

I got inspiration from Woo Subscriptions:

I don't know if this is the best inspiration. It is a bit of confusing link. I already created an issue for that: https://github.com/pronamic/pronamic-pay/issues/97. We are now introducing the same issue here 😉.

Not entirely, in the current implementation the links are provided with descriptions. But I was aware of this, which is why I came up with an alternative.

The primary task of the element is "Sharing the action links" with the customer.

This is not the case, I have used the current links regularly. I won't use copying the links much myself. But seeing what the pages look like and what I share with the customer is something I am more likely to do. I also find it difficult to imagine that there are administrators who blindly copy this link and pass it on to their customer, you want to know what you are sharing with a customer. In that respect, it seems to me that the 'View page' is the primary function, and the copy link functionality is secondary.

[rvdsteege]

FWIW, I think we should go with this… both 'view' and 'copy' can be used this way and satisfies all use cases: