Closed remcotolsma closed 2 months ago
⚠️ 🚨 Another important addition: In the screenshot, the fixed periods settings is set to 2
, which currently results in 1
period in the alignment phase and 1
period in the regular phase. After the proposed change it will result in 1
period in the alignment phase and 2
periods in the regular phase. This because we believe that this makes more sense? Otherwise the following entry/payment would result in only one alignment period:
Interval: 1 year Fixed periods: 1 Alignment date: January 1 Entry date: December 15, 2024
This would make more sense?
For this client we can change the fixed periods setting from 2
to 1
, for other clients a changelog note?
Re-opening for "Improve user interface in Gravity Forms subscription alignment settings".
The name and description of the setting are already updated in https://github.com/pronamic/wp-pronamic-pay-gravityforms/commit/df49d2d9a370ab0515f309914dbc1c506dfaa7c1.
Closing this issue, moved the open task to the Pronamic Pay Gravity Forms repository:
Through a customer we discovered a problem with subscription phase alignment for subscriptions with an end date.
Internal HelpScout tickets:
Discussed with @rvdsteege at @Pronamic HQ, the solution consists of 3 parts.
Allow partial periods in subscription phase period creation
Related code:
https://github.com/pronamic/wp-pay-core/blob/b0a6a19963b5615996ef11cadcfc50b7e8a1b494/src/Subscriptions/SubscriptionPhase.php#L487-L491
No longer use total periods in subscription alignment
Related code:
https://github.com/pronamic/wp-pay-core/blob/b0a6a19963b5615996ef11cadcfc50b7e8a1b494/src/Subscriptions/SubscriptionPhase.php#L674-L694
It would be easier to understand if we extend a possible regular phase end date with the alignment period/interval?
Improve user interface in Gravity Forms subscription alignment settings
Related code:
https://github.com/pronamic/wp-pronamic-pay-gravityforms/blob/325d139b0c88ae43647d639159e3c64551143369/views/html-admin-feed-settings.php#L805-L985
Suggested change in Dutch: