Subscription phase alignment issue for subscriptions with end date

remcotolsma commented 2 months ago

Through a customer we discovered a problem with subscription phase alignment for subscriptions with an end date.

Internal HelpScout tickets:

Discussed with @rvdsteege at @Pronamic HQ, the solution consists of 3 parts.

[x] Allow partial periods in subscription phase period creation
[x] No longer use total periods in subscription alignment
[ ] Improve user interface in Gravity Forms subscription alignment settings

Allow partial periods in subscription phase period creation

    if ( null !== $this->end_date && $end_date > $this->end_date ) {
        // Should we check if start date is before $this->end_date?
        $end_date = $this->end_date;
    }

No longer use total periods in subscription alignment

It would be easier to understand if we extend a possible regular phase end date with the alignment period/interval?

Improve user interface in Gravity Forms subscription alignment settings

Suggested change in Dutch:

Betalingsdatum uitlijnen ☑️ Betalingsdatum uitlijnen inschakelen Het is mogelijk om de eerst volgende betalingsdatum uit te lijnen op een vaste dag van de week, maand of jaar. Hiervoor wordt er een extra abonnementsfase toegevoegd aan het begin van het abonnement. Als het aantal perioden vast staat ingesteld krijg je er dus altijd 1 extra periode bij. Het af te rekenen bedrag voor deze uitlijningsfase kan naar rato worden berekend.

remcotolsma commented 2 months ago

⚠️ 🚨 Another important addition: In the screenshot, the fixed periods settings is set to 2, which currently results in 1 period in the alignment phase and 1 period in the regular phase. After the proposed change it will result in 1 period in the alignment phase and 2 periods in the regular phase. This because we believe that this makes more sense? Otherwise the following entry/payment would result in only one alignment period:

Interval: 1 year Fixed periods: 1 Alignment date: January 1 Entry date: December 15, 2024

This would make more sense?

Alignment period: December 15, 2024 - December 31, 2024
Regular period: January 1, 2025 - December 31, 2025

For this client we can change the fixed periods setting from 2 to 1, for other clients a changelog note?

rvdsteege commented 2 months ago

Re-opening for "Improve user interface in Gravity Forms subscription alignment settings".

The name and description of the setting are already updated in https://github.com/pronamic/wp-pronamic-pay-gravityforms/commit/df49d2d9a370ab0515f309914dbc1c506dfaa7c1.

remcotolsma commented 2 months ago

Closing this issue, moved the open task to the Pronamic Pay Gravity Forms repository:

https://github.com/pronamic/wp-pronamic-pay-gravityforms/issues/46

pronamic / wp-pay-core