Add iDEAL issuer N26 - Githubissues

remcotolsma commented 1 year ago

https://github.com/pronamic/pronamic-pay/issues/59

https://github.com/pronamic/wp-pay-logos/tree/main/src/ideal-issuers

LeoOosterloo commented 1 year ago

I saw this one by chance. So already made the SVG's for this issuer.

N26.zip

remcotolsma commented 1 year ago

Just informed our partner @Mollie about their different N26 image.

All the iDEAL issuer SVG images are 32 × 24, see for example:

The new iDEAL issuer N26 however is 30 × 30:

https://www.mollie.com/external/icons/ideal-issuers/NTSBDEB1.svg

<svg width="30" height="30" viewBox="0 0 30 30" fill="none" xmlns="http://www.w3.org/2000/svg">
<g clip-path="url(#clip0_2835_170)">
<path d="M2.1967 27.8033C4.3934 30 7.92893 30 15 30C22.0711 30 25.6066 30 27.8033 27.8033C30 25.6066 30 22.0711 30 15C30 7.92893 30 4.3934 27.8033 2.1967C25.6066 0 22.0711 0 15 0C7.92893 0 4.3934 0 2.1967 2.1967C0 4.3934 0 7.92893 0 15C0 22.0711 0 25.6066 2.1967 27.8033Z" fill="#48AC98"/>
<path d="M10.7661 5.625H19.2339V6.83468H10.7661V5.625ZM17.7695 9.85887V17.1018H17.7689C17.7689 17.7496 17.7841 18.1415 17.8143 18.5183H17.7841C17.6256 18.0871 17.4387 17.7091 17.1605 17.2167L12.8322 9.85887H10.7661V20.1411H12.3955V13.1631H12.3968C12.3968 12.5147 12.3816 12.1234 12.3514 11.7466H12.3816C12.5395 12.1778 12.7264 12.5558 13.0046 13.0476L17.4193 20.1411H19.2339V9.85887H17.7695ZM10.7661 23.1653H19.2339V24.375H10.7661V23.1653Z" fill="white"/>
</g>
<defs>
<clipPath id="clip0_2835_170">
<rect width="30" height="30" rx="7.5" fill="white"/>
</clipPath>
</defs>
</svg>

This may not be quite the right repository for reporting this anomaly, but I couldn't find another suitable GitHub repository.

http -A bearer -a test_●●●●●●●●●●●●●●●●●●●●●●●●●●●●●● https://api.mollie.com/v2/methods/all\?include\=issuers

{
    "id": "ideal_KNABNL2H",
    "image": {
        "size1x": "https://www.mollie.com/external/icons/ideal-issuers/KNABNL2H.png",
        "size2x": "https://www.mollie.com/external/icons/ideal-issuers/KNABNL2H%402x.png",
        "svg": "https://www.mollie.com/external/icons/ideal-issuers/KNABNL2H.svg"
    },
    "name": "Knab",
    "resource": "issuer"
},
{
    "id": "ideal_NTSBDEB1",
    "image": {
        "size1x": "https://www.mollie.com/external/icons/ideal-issuers/NTSBDEB1.png",
        "size2x": "https://www.mollie.com/external/icons/ideal-issuers/NTSBDEB1%402x.png",
        "svg": "https://www.mollie.com/external/icons/ideal-issuers/NTSBDEB1.svg"
    },
    "name": "N26",
    "resource": "issuer"
},
{
    "id": "ideal_RBRBNL21",
    "image": {
        "size1x": "https://www.mollie.com/external/icons/ideal-issuers/RBRBNL21.png",
        "size2x": "https://www.mollie.com/external/icons/ideal-issuers/RBRBNL21%402x.png",
        "svg": "https://www.mollie.com/external/icons/ideal-issuers/RBRBNL21.svg"
    },
    "name": "Regiobank",
    "resource": "issuer"
},

I think the PNGs from N26 also have a different format. Is this something you can improve?

Source: https://github.com/mollie/api-documentation/issues/964

remcotolsma commented 1 year ago

I created an own 'Mollie' icon for iDEAL issuer N26 and added it in https://github.com/pronamic/wp-pay-logos/blob/main/src/ideal-issuers/n26/ideal-issuer-n26-mollie-32x24.svg. We currently have no other variants for the iDEAL issuers in this library, so the SVGs @LeoOosterloo created are not added and/or in use for now. As soon as Mollie has its own N26 icon in the correct format, we can of course start using it, awaiting https://github.com/mollie/api-documentation/issues/964.

pronamic / wp-pay-logos

Add iDEAL issuer N26 #9