pronamic / wp-pronamic-pay-give

Give driver for the WordPress payment processing library.
http://www.wp-pay.org/extensions/give/
3 stars 1 forks source link

Regarding Support for Visual Form Builder #6

Closed knit-pay closed 5 months ago

knit-pay commented 5 months ago

Hello Team

Give has introduced Visual Form Builder in Give v3. This code is currently not compatible with Visual Form Builder, similar to Charitable https://github.com/pronamic/wp-pronamic-pay-charitable/issues/5

For old form builder Pronamic is available. image

For Visual Form Builder Pronamic is missing. image

rvdsteege commented 5 months ago

I looked in to this a bit today and it seems that adding support for the visual form builder ("version 3") seems to require more or less a rewrite of the integration, which we currently don't have any plans for.

Give also states at https://givewp.com/documentation/core/givewp-3-0-compatibility-guide/ that the options-based editor won't go away soon:

The GiveWP team is committed to maintaining support for any functionality currently possible, until that functionality can be reasonably and easily replicated in the new Form Editing experience. Forms created with the options-based form editor will be supported for the foreseeable future.

You're welcome to open a PR though. To add support you'd need to hook the action givewp_register_payment_gateway to register gateways that extends from Give\Framework\PaymentGateways\PaymentGateway (example at https://github.com/impress-org/givewp-example-gateway).