pronamic / wp-pronamic-pay-ingenico

Worldline (formerly Ingenico/Ogone) driver for the WordPress payment processing library.
http://www.wp-pay.org/gateways/ingenico/
5 stars 1 forks source link

Remove `DirectLink` integration, is not used anymore #15

Closed remcotolsma closed 11 months ago

remcotolsma commented 1 year ago

In our usage statistics we see that the 'DirectLink' integration is not used, so there is no added value in maintaining it anymore.

rvdsteege commented 1 year ago

After discussion with @remcotolsma at Pronamic HQ, I checked if the DirectLink integration is somehow in use for retrieval of order statuses in the OrderStandard integration. The request to a direct query URL is in the client of the OrderStandard integration:

https://github.com/pronamic/wp-pronamic-pay-ingenico/blob/c430deb4f209521925170068f1bdf5fcd5443da5/src/OrderStandard/Client.php#L271-L328

The request response gets parsed through the Pronamic\WordPress\Pay\Gateways\Ingenico\XML\OrderResponseParser class, which in turn currently uses a Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink\OrderResponse class from the DirectLink integration. However, I think we can do without that almost empty class — used for converting a SimpleXML array to object:

https://github.com/pronamic/wp-pronamic-pay-ingenico/blob/c430deb4f209521925170068f1bdf5fcd5443da5/src/DirectLink/OrderResponse.php#L1-L45

https://github.com/pronamic/wp-pronamic-pay-ingenico/blob/c430deb4f209521925170068f1bdf5fcd5443da5/src/XML/OrderResponseParser.php#L19-L51

rvdsteege commented 11 months ago

ℹ️ Removed integrations from plugins: