pronamic / wp-pronamic-pay-memberpress

MemberPress driver for the WordPress payment processing library.

http://www.wp-pay.org/extensions/memberpress/

4 stars 1 forks source link

Update Payment Status for Failed payments #1

Closed knit-pay closed 2 years ago

knit-pay commented 3 years ago

In some payment gateways, the buyer can retry the failed payment. So, it's important to update status in memberpress also if payment is now complete.

codecov-io commented 3 years ago

Codecov Report

Merging #1 into master will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff            @@
##             master      #1   +/-   ##
========================================
  Coverage      1.11%   1.11%           
  Complexity      199     199           
========================================
  Files            19      19           
  Lines           806     805    -1     
========================================
  Hits              9       9           
+ Misses          797     796    -1

Impacted Files	Coverage Δ	Complexity Δ
src/Extension.php	`0.00% <ø> (ø)`	`41.00 <0.00> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67887f9...0ab9e5e. Read the comment docs.

knit-pay commented 3 years ago

Hello @remcotolsma and @rvdsteege

Have you checked it?

knit-pay commented 2 years ago

Hello Team

Is there an update on this?

rvdsteege commented 2 years ago

@remcotolsma I don't think we want to update failed MemberPress transactions?

Should gateway integrations which support retrying a payment (after being redirected back to the website) not update the status of the Pronamic payment to 'Failed' and leave them 'Pending' instead?

knit-pay commented 2 years ago

@rvdsteege and @remcotolsma I think you need more clarity regarding this issue. Some payment gateway supports retrying of failed payments. After payment gets failed, they send a webhook to the website which makes payment status fail in Memberpress after some time when the user retries the payment, the payment gets successful but because of this issue, the order is not getting marked as complete in memberpress.

rvdsteege commented 2 years ago

@knit-pay discussed at the office with @remcotolsma and merged 🎉 Sorry for the long wait!