Remove check for empty version option.

pronamic / wp-pronamic-pay-mollie

Mollie driver for the WordPress payment processing library.

http://www.wp-pay.org/gateways/mollie/

6 stars 1 forks source link

Remove check for empty version option. #22

Closed rvdsteege closed 1 year ago

rvdsteege commented 1 year ago

Fix #21.

rvdsteege commented 1 year ago

@remcotolsma I think addition of the null default value in AbstractIntegration::get_version_option() is the cause of the changed behavior:

https://github.com/pronamic/wp-pay-core/commit/142f77f91c28e91a6aebd8fcea7e8dc1e6648a0f#diff-3b7c7220625122ae35b9ab52e09325a7d6ee3540547688214413f3bf9d3c742bR242

Previously on first run, $this->integration->get_version_option() in the Mollie installer would result in false — but now it's null. This PR still resolves that.

remcotolsma commented 1 year ago

Discussed @pronamic HQ with @rvdsteege, changed in https://github.com/pronamic/wp-pronamic-pay-mollie/commit/ba3511097e85f5292edcf5d8d3542110ceb21374.