search

pronamic / wp-pronamic-pay-ninjaforms

Ninja Forms driver for the WordPress payment processing library.
http://www.wp-pay.org/extensions/ninjaforms/
2 stars 1 forks source link

Ninja Forms payment method field values too error prone #7

Open remcotolsma opened 3 years ago

remcotolsma commented 3 years ago

In internal HelpScout ticket https://secure.helpscout.net/conversation/1641517421/22778/ we had a customer who added the payment method iDEAL with the label iDEAL and also the value iDEAL, this while the value ideal is required for the iDEAL payment method. I think this problem also sometimes occurs with Gravity Forms, so I think this setup is too error-prone. How can we improve or simplify this?

Schermafbeelding 2021-09-27 om 11 55 50
rvdsteege commented 3 years ago

The correct values to use are filled out when adding the payment method field. Why would the user change the value? When unsure about which values to use (when not getting redirected to the correct payment method on form submission), a new payment method field can easily be added — as replacement or reference.

Unfortunately, Ninja Forms does not seem to use some kind of pre-defined lists when 'importing' field options, as we hook into with for example Formidable Forms to add payment method options with the correct values in an existing payment method field.

As for Gravity Forms: the values of currently active payment methods can not be changed in a payment method field. I don't see any issues there (also not in support).