Rabo Smart Pay difference between order ID and transaction ID

[remcotolsma]

When starting a Rabo Smart Pay payment, we use the https://betalen.rabobank.nl/omnikassa-api/order/server/api/v2/order endpoint: https://developer.rabobank.nl/product/9981/api/9770#/RaboSmartPayOnlinePaymentAPI_1013/operation/%2Forder%2Fserver%2Fapi%2Fv2%2Forder/post

We receive an omnikassaOrderId in the response:

{
  "redirectURL": "https://betalen.rabobank.nl/omnikassa/nl/payment-brand?token=eyJraWQiOiJFTU8iLCJhbGciOiJFUzI1NiJ9.eyJlbW8iOiJhYWZhMDAxM",
  "omnikassaOrderId": "1d0a95f4-2589-439b-9562-c50aa19f9caf"
}

We save this omnikassaOrderId as transaction ID in the Pronamic payment:

https://github.com/pronamic/wp-pronamic-pay-omnikassa-2/blob/d09ad0e964f907625e11d66dd227a92299da092e/src/Gateway.php#L422-L426

However, there is no overview of 'orders' in the Rabo Smart Pay dashboard, only transactions. The omnikassaOrderId cannot be found at all in the Rabo Smart Pay dashboard. This makes it confusing that we do store and display it as a transaction ID.

Currently we also use the \get_pronamic_payment_by_transaction_id( $omnikassa_order_id ) to find the Pronamic Pay payment:

https://github.com/pronamic/wp-pronamic-pay-omnikassa-2/blob/d09ad0e964f907625e11d66dd227a92299da092e/src/Gateway.php#L557-L575

When requesting order status changes after a webhook call from the Rabo Smart Pay, it is possible to get the transactions of an order returned with the new v2 API: https://betalen.rabobank.nl/omnikassa-api/order/server/api/v2/events/results/merchant.order.status.changed

{
  "moreOrderResultsAvailable": true,
  "orderResults": [
    {
      "merchantOrderId": "order123",
      "omnikassaOrderId": "1d0a95f4-2589-439b-9562-c50aa19f9caf",
      "poiId": "2004",
      "orderStatus": "COMPLETED",
      "orderStatusDateTime": "2018-11-25T12:20:03.157+00:00",
      "errorCode": "cajcodjijuuvof",
      "paidAmount": {
        "amount": 10997,
        "currency": "EUR"
      },
      "totalAmount": {
        "amount": 10997,
        "currency": "EUR"
      },
      "transactions": [
        {
          "transactionId": "22b36073-57a3-4c3d-9585-87f2e55275a5",
          "paymentBrand": "IDEAL",
          "transactionType": "AUTHORIZE",
          "transactionStatus": "SUCCESS",
          "amount": {
            "amount": 10997,
            "currency": "EUR"
          },
          "confirmedAmount": {
            "amount": 10997,
            "currency": "EUR"
          },
          "startDateTime": "2018-03-20T09:12:28Z",
          "lastUpdateTime": "2018-03-20T09:12:28Z"
        }
      ]
    },
    {
      "merchantOrderId": "order123",
      "omnikassaOrderId": "1d0a95f4-2589-439b-9562-c50aa19f9caf",
      "poiId": "2004",
      "orderStatus": "COMPLETED",
      "orderStatusDateTime": "2018-11-25T12:20:03.157+00:00",
      "errorCode": "telibirvameb",
      "paidAmount": {
        "amount": 10997,
        "currency": "EUR"
      },
      "totalAmount": {
        "amount": 10997,
        "currency": "EUR"
      },
      "transactions": [
        {
          "transactionId": "22b36073-57a3-4c3d-9585-87f2e55275a5",
          "paymentBrand": "IDEAL",
          "transactionType": "AUTHORIZE",
          "transactionStatus": "SUCCESS",
          "amount": {
            "amount": 10997,
            "currency": "EUR"
          },
          "confirmedAmount": {
            "amount": 10997,
            "currency": "EUR"
          },
          "startDateTime": "2018-03-20T09:12:28Z",
          "lastUpdateTime": "2018-03-20T09:12:28Z"
        }
      ]
    },
    {
      "merchantOrderId": "order123",
      "omnikassaOrderId": "1d0a95f4-2589-439b-9562-c50aa19f9caf",
      "poiId": "2004",
      "orderStatus": "COMPLETED",
      "orderStatusDateTime": "2018-11-25T12:20:03.157+00:00",
      "errorCode": "nibomd",
      "paidAmount": {
        "amount": 10997,
        "currency": "EUR"
      },
      "totalAmount": {
        "amount": 10997,
        "currency": "EUR"
      },
      "transactions": [
        {
          "transactionId": "22b36073-57a3-4c3d-9585-87f2e55275a5",
          "paymentBrand": "IDEAL",
          "transactionType": "AUTHORIZE",
          "transactionStatus": "SUCCESS",
          "amount": {
            "amount": 10997,
            "currency": "EUR"
          },
          "confirmedAmount": {
            "amount": 10997,
            "currency": "EUR"
          },
          "startDateTime": "2018-03-20T09:12:28Z",
          "lastUpdateTime": "2018-03-20T09:12:28Z"
        }
      ]
    }
  ],
  "signature": "99ca2487243fbad72bbaa456a3219db7b0d2a19777f436cedb3c045e999b86c05001bb0837b43caa3d1757321d00959ac2a161f473a103af72bf440db5147b4a"
}

We currently use the following API endpoint: https://developer.rabobank.nl/product/9981/api/9770#/RaboSmartPayOnlinePaymentAPI_1013/operation/%2Forder%2Fserver%2Fapi%2Fevents%2Fresults%2Fmerchant.order.status.changed/get

https://github.com/pronamic/wp-pronamic-pay-omnikassa-2/blob/d09ad0e964f907625e11d66dd227a92299da092e/src/Client.php#L272-L286

I suggest we do the following things:

• [x] No longer store omnikassaOrderId as the Pronamic Pay payment transaction ID.
• [x] Store the omnikassaOrderId in the payment via wp_posts.post_name so that we can query the Pronamic Pay payment much faster. The implementation of get_pronamic_payment_by_transaction_id involves a heavy meta query:
  • https://github.com/pronamic/wp-pay-core/blob/c948b2faba6f08f3f5c4d3595e7806fee63c094f/includes/functions.php#L119-L128
• [x] If "orderStatus": "COMPLETED" store first "transactionStatus": "SUCCESS" transaction ID in the Pronamic Pay payment.
• [x] If "orderStatus": "X" store first "transactionStatus": "Y" transaction ID in the Pronamic Pay payment.
• [x] Fix the refund feature, this requires a transaction ID, not an order ID.
  • https://developer.rabobank.nl/product/9981/api/9770#/RaboSmartPayOnlinePaymentAPI_1013/operation/%2Forder%2Fserver%2Fapi%2Fv2%2Frefund%2Ftransactions%2F{transaction_id}%2Frefunds/post
• [x] etc.

The following 4 transactions are all for the same Rabo Smart Pay order:

• Order ID = 5db65e5a-be4b-414b-9f2f-f3ade91609c0
  • Transaction 1 ID =95d329fe-2999-4e95-b7cb-2ef992d224ef
  • Transaction 2 ID = 5ed46c09-13d3-4f93-9965-115d4f537a3a
  • Transaction 3 ID = 71bb15d1-34ad-4669-bf83-da4b2f970598
  • Transaction 4 ID = 3d42c332-befc-427b-96fb-26b39f15ff61

Internal HelpScout ticket: https://secure.helpscout.net/conversation/2310345880/25945/

[remcotolsma]

Wrote an unit test today and fixed some last issues:

https://github.com/pronamic/wp-pronamic-pay-omnikassa-2/blob/3560964c8c2f78bd14df116aa407f701fa562cec/tests/src/WebhookControllerTest.php#L65-L154