search

pronamic / wp-pronamic-pay-woocommerce

WooCommerce driver for the WordPress payment processing library.
http://www.wp-pay.org/extensions/woocommerce/
6 stars 2 forks source link

37 no customer and payment lines #40

Closed remcotolsma closed 1 year ago

rvdsteege commented 1 year ago

Quick note, because @remcotolsma and I were wondering how some subscriptions could have a next payment date when there is no next payment: when a phase is added with Subscription::add_phase( $phase ) and the subscription next payment date is null, the phase start date is set as next payment date.

https://github.com/pronamic/wp-pronamic-pay-woocommerce/blob/f21bf0b8b83e0c5682a9b3825356d8b423714e59/src/SubscriptionUpdater.php#L179-L180

https://github.com/pronamic/wp-pay-core/blob/76cdf8aa10c9b16b20755da41e070abc4a4c6b5f/src/Subscriptions/Subscription.php#L708-L722

remcotolsma commented 1 year ago
  1. Payments without period are not listed in the subscription payments meta box.

New issue:

  1. For subscription products that have the 'Expire after' set and result in no recurrence, the subscription does not have a next payment date on creation (correct), however, during the payment status update, the next payment date is set, incorrectly resulting in the "Will be created on [date]" notice in the payments meta box and a incorrect next payment date mentioned in the subscription info meta box.

This is fixed: https://github.com/pronamic/wp-pay-core/commit/a26863b099739babe9e286049c593a2aeee2489a and https://github.com/pronamic/wp-pronamic-pay-woocommerce/commit/133a5ad1dcb7a2f95d9b7c6f11926059f9445ef3.