Pending payment != pending payment status

For a customer an automatic WooCommerce Subscriptions renewal order #5326 was created on Sunday, June 23, 2024, with the associated Mollie direct debit payment. This renewal order #5326 automatically received the status 'Pending payment', because the direct debit payment had not yet been received. However, on Monday June 24, 2024, the customer logged in to his account page and saw order #5326 with the status 'Pending payment' and a 'Pay' button. The customer was of course not aware that a direct debit was already in progress and used the 'Pay' button to pay for order #5326 via iDEAL. On Tuesday, June 25, 2024, the direct debit payment was also received and payment was made twice for order #5326. Therefore, we think that 'pending payment' is not the correct status when a payment is in progress, 'on hold' seems to be a better choice. This is also better with other payment methods such as iDEAL, because in theory status feedback can take a few hours. During that time, you don't actually want the customer to initiate payment again for this order.

https://github.com/pronamic/wp-pronamic-pay-woocommerce/blob/d1d004f9cf01a759147948d3060919c0fe6bf2d8/src/Extension.php#L478-L489

CC @rvdsteege

pronamic / wp-pronamic-pay-woocommerce

Pending payment != pending payment status #70