search

pronamic / wp-pronamic-pay

The Pronamic Pay plugin allows you to easily accept payments with payment methods like credit card, iDEAL, Bancontact and Sofort through a variety of payment providers on your WordPress website.
https://pronamicpay.com
34 stars 14 forks source link

Store `_pronamic_payment_method` in JSON #230

Closed remcotolsma closed 2 years ago

remcotolsma commented 2 years ago

For subscriptions we use _pronamic_subscription_payment_method or subscription.payment_method should we also use payment.payment_method or stick to just simply payment.method?

Stripe uses PaymentIntent.payment_method: https://stripe.com/docs/api/payment_intents/object#payment_intent_object-payment_method

Mollie uses Payment.method: https://docs.mollie.com/reference/v2/payments-api/create-payment

@rvdsteege ?

rvdsteege commented 2 years ago

@remcotolsma I thought of renaming to payment.payment_method.

Just method could be any method, for example HTTP method GET/POST. I think payment_method is more descriptive.

remcotolsma commented 2 years ago

Agree, fixed in https://github.com/pronamic/wp-pay-core/commit/f37160f8c73017e15ad5ba5b799db38009da12fc.