Introduce a `$gateway->can_retry_payment( Payment $payment )` function?

[remcotolsma]

No longer use ( ! $payment->get_recurring() ) condition to determine a payment can be retried, maybe we should ask this to each $gateway? A Mollie payment can be retried if there is valid mandate ID?

https://github.com/pronamic/wp-pay-core/commit/41ecb7a7040310591642d9386d8c012cb174bb0a

[rvdsteege]

A Mollie payment can be retried if there is valid mandate ID?

There could be a mandate, but it should not be possible to retry a first payment even though there is a mandate.

[remcotolsma]

Then the question is why shouldn't a first payment that has failed be retried if there is a mandate that makes it possible? It may also be questionable whether a payment can be retried without interaction, with interaction every payment can be made again. It is not possible to automatically process a failed iDEAL payment again without interaction. I don't think this issue is a must within the "Subscriptions follow-up payments improvements" project, we can also improve / devise it at a later stage.

[rvdsteege]

Then the question is why shouldn't a first payment that has failed be retried if there is a mandate that makes it possible?

Because that would activate this subscription, while the user probably tried again themselves and already has an active subscription. Activating this subscription would mean duplicate payments in the future.

I don't think this issue is a must within the "Subscriptions follow-up payments improvements" project, we can also improve / devise it at a later stage.

👍

[remcotolsma]

This is no longer up to date, we already have a solution for this:

https://github.com/pronamic/wp-pronamic-pay-mollie/blob/ba457cec96fa7ff42eb71a208a5be95c058fd3ed/src/Gateway.php#L396-L446