pronamic / wp-pronamic-pay

The Pronamic Pay plugin allows you to easily accept payments with payment methods like credit card, iDEAL, Bancontact and Sofort through a variety of payment providers on your WordPress website.
https://pronamicpay.com
34 stars 14 forks source link

Error on Gateway Configuration Page #268

Closed knit-pay closed 2 years ago

knit-pay commented 2 years ago

Hello Team

Some of my clients are getting errors on the Gateway Configuration page, do you have any idea about the same? Only a few clients getting this error.

[30-Oct-2021 13:39:59 UTC] PHP Parse error: syntax error, unexpected 'print' (T_PRINT), expecting identifier (T_STRING) in /home/g31tiroke5m1/public_html/wp-content/plugins/pronamic-ideal/vendor/pronamic/wp-html/src/Element.php on line 104

knit-pay commented 2 years ago

@remcotolsma

I found the solution. The issue is with the function name print. This is a reserved keyword of PHP. That's why it is causing issues in a few PHP versions. Renaming this function to something else (eg display) will fix the issue

https://github.com/pronamic/wp-html/blob/8a99734168c3086eb3de773215117354a0fe0bce/src/Element.php#L104

rvdsteege commented 2 years ago

Thank you Gautam, I was able to reproduce the issue and have resolved it by renaming the method to output() instead.

knit-pay commented 2 years ago

Thanks @rvdsteege When are you planning to release the next update?

rvdsteege commented 2 years ago

We don't know yet. We've made some major performance related optimisations in core for Pronamic Pay 8.0; storing less post meta for example. We're removing/reworking some (legacy/deprecated) Payment and Subscription properties and need to address some final issues before we can release an update. This will probably take some few weeks.

knit-pay commented 2 years ago

Thanks for the information. Waiting to see new version soon :)