search

pronamic / wp-pronamic-pay

The Pronamic Pay plugin allows you to easily accept payments with payment methods like credit card, iDEAL, Bancontact and Sofort through a variety of payment providers on your WordPress website.
https://pronamicpay.com
34 stars 14 forks source link

Increase minimum PHP requirement to `7.4`? #274

Closed remcotolsma closed 2 years ago

remcotolsma commented 2 years ago

As far as I'm concerned we require PHP 7.4, this is already the recommendation from WordPress: https://wordpress.org/about/requirements/. PHP 7.3 only has security support until 6 dec 2021: https://www.php.net/supported-versions.php.

Originally posted by @remcotolsma in https://github.com/pronamic/wp-pronamic-pay/issues/271#issuecomment-961694462

rvdsteege commented 2 years ago

A roughly estimated 70% of Pronamic Pay users seem to use PHP version >= 7.4, based on support (YTD). The current percentage is probably a little higher.

As active support for PHP 7.4 ends in 3 weeks and WordPress also recommends PHP version 7.4, I think it's fine to bump the minimum PHP version requirement to 7.4.

Schermafbeelding 2021-11-05 om 09 37 00
remcotolsma commented 2 years ago

Increased it in https://github.com/pronamic/wp-pronamic-pay/commit/076cdedb2584a07e61a4b3ce95b82cbfab74290e. As soon as we work on extensions and gateways, we can also implement the increase there. No need to apply it everywhere at once.