search

pronamic / wp-pronamic-pay

The Pronamic Pay plugin allows you to easily accept payments with payment methods like credit card, iDEAL, Bancontact and Sofort through a variety of payment providers on your WordPress website.
https://pronamicpay.com
34 stars 14 forks source link

Gravity Forms » Alignment payment method icons #312

Closed LeoOosterloo closed 2 years ago

LeoOosterloo commented 2 years ago

The 'Payment methods' fields get a default gf_list_2col CSS-class. If i want to change that to gf_list_3col or gf_list_inline the 2 columns css-class is still added...

Schermafbeelding 2022-02-28 om 16 05 20

The items also get quite some white space in front of them.

Can we change the way we display payment methods when 'list with icons' 'small icons' or 'large icons' is selected?

rvdsteege commented 2 years ago

We could maybe change https://github.com/pronamic/wp-pronamic-pay-gravityforms/blob/4.0.1/src/PaymentMethodsField.php#L122 to only search for gf_list_, so it won't add the gf_list_2col CSS class if any gf_list_* class is found (@remcotolsma?).

As for the spacing, that is theme territory — we're not adding the additional space in front of the icons from our plugin.

remcotolsma commented 2 years ago

We could maybe change https://github.com/pronamic/wp-pronamic-pay-gravityforms/blob/4.0.1/src/PaymentMethodsField.php#L122 to only search for gf_list_, so it won't add the gf_list_2col CSS class if any gf_list_* class is found (@remcotolsma?).

Seems fine to me.