Subscription 'On Hold' by expired mandate change payment, not reactivated with later successful mandate change payment

[rvdsteege]

The following scenario occurred when trying to update the mandate for a subscription:

• a payment for mandate change was started and abandoned, after 15 minutes the payment status got updated to 'Expired', which resulted in the subscription being put 'On Hold';
• later that day, a second payment for mandate change has been completed successfully;
• after the 2nd payment, the subscription is still 'On Hold' and no follow-up payments were created after that time.

Note: customer is using Pronamic Pay version 7.0.2, I've not yet tried to reproduce this with the latest release.

My first thought is that the first expired payment should not have resulted in the subscription status being updated to 'On Hold', as mandate changes should probably not have any influence on the activation status of the subscription.

Internal Help Scout ticket: https://secure.helpscout.net/conversation/1831339824/23764/

[rvdsteege]

Tested and unable to reproduce.

Seems to be resolved with https://github.com/pronamic/wp-pay-core/commit/e9d28d8957ab8daff7312c385b4852eb606217c0 as $subscription->is_first_payment( $payment ) uses the payment periods.

• https://github.com/pronamic/wp-pay-core/blob/4.0.2/src/Subscriptions/SubscriptionsModule.php#L168-L175