pronamic / wp-pronamic-pay

The Pronamic Pay plugin allows you to easily accept payments with payment methods like credit card, iDEAL, Bancontact and Sofort through a variety of payment providers on your WordPress website.
https://pronamicpay.com
34 stars 14 forks source link

Gateways / payment methods input fields API 🔁2️⃣ #336

Closed remcotolsma closed 1 year ago

remcotolsma commented 1 year ago

Source: https://github.com/pronamic/wp-pronamic-pay/issues/154#issuecomment-1222428469

rvdsteege commented 1 year ago

Remove IDealIssuerSelectField class, just use general SelectField class?

We might want to do something with last used issuer etc., would a specific IDealIssuerSelectField class not make that easier to accomplish (if we are going to map the issuers to a core constant)?

remcotolsma commented 1 year ago

Yes, but i don't think it's good practice that it requires a subclass. We could also use an id or type property to identify specific fields:

rvdsteege commented 1 year ago

Todo for 'Add support for OmniKassa and AfterPay.nl gender and birthdate field':

remcotolsma commented 1 year ago

For now, we are satisfied with the current implementation.