Closed remcotolsma closed 1 year ago
Remove IDealIssuerSelectField class, just use general SelectField class?
We might want to do something with last used issuer etc., would a specific IDealIssuerSelectField
class not make that easier to accomplish (if we are going to map the issuers to a core constant)?
Yes, but i don't think it's good practice that it requires a subclass. We could also use an id
or type
property to identify specific fields:
Todo for 'Add support for OmniKassa and AfterPay.nl gender and birthdate field':
For now, we are satisfied with the current implementation.
IDealIssuerSelectField
class, just use generalSelectField
class?Source: https://github.com/pronamic/wp-pronamic-pay/issues/154#issuecomment-1222428469