pronamic / wp-pronamic-pay

The Pronamic Pay plugin allows you to easily accept payments with payment methods like credit card, iDEAL, Bancontact and Sofort through a variety of payment providers on your WordPress website.
https://pronamicpay.com
34 stars 14 forks source link

Reconsider PHP 8 requirement #353

Closed rvdsteege closed 1 year ago

rvdsteege commented 1 year ago

The increased PHP version requirement to 8.0 seems to be causing some issues / frustrations:

Ik vind dat jullie er wel vrij vroeg bij zijn om PHP8 te eisen. Miljoenen websites draaien daar nog niet op.

De host geeft aan dat hun systeem nog niet klaar is voor een PHP update.

On our site, currently the Customizer is broken (it doesn't load). In the error logs I see the followwing:

PHP Fatal error: Uncaught TypeError: Return value of Pronamic\WordPress\Pay\Fields\Field::jsonSerialize() must be an instance of Pronamic\WordPress\Pay\Fields\mixed, array returned in /wp-content/plugins/pronamic-ideal/vendor/wp-pay/core/src/Fields/Field.php:149

Recently, the following error message is displayed for the Pronamic plugin

This plugin does not work with your version of PHP

This is the PHP version running on my server: 7.4.33. Is this PHP version too old to run the plugin?

PHP 7.4 compatibility has already been improved in https://github.com/pronamic/wp-pay-core/commit/b59cc53ae4974de599b4c635651f992173d87007, but maybe we should also reconsider the increased PHP version requirement?

For reference:

Internal Help Scout tickets:

remcotolsma commented 1 year ago

Because almost no PHP 8+ functionalities are used yet, it seems fine to me to continue to support PHP 7.4 for now. I have already modified the libraries, will patch them shortly.