search

pronamic / wp-pronamic-pay

The Pronamic Pay plugin allows you to easily accept payments with payment methods like credit card, iDEAL, Bancontact and Sofort through a variety of payment providers on your WordPress website.
https://pronamicpay.com
35 stars 14 forks source link

Fatal error: Access level to Pronamic_EasyDigitalDownloads_PaymentData::$payment_id must be public #87

Closed BjornW closed 10 years ago

BjornW commented 10 years ago

PHP Fatal error: Access level to Pronamic_EasyDigitalDownloads_PaymentData::$payment_id must be public (as in class Pronamic_WP_Pay_PaymentData) in /wp-content/plugins/pronamic-ideal/classes/Pronamic/EasyDigitalDownloads/PaymentData.php on line 11

I get this error message when I try to connect to the Buckaroo payment Gateway. I'm using Fundify as theme in combination with Easy Digital Downloads (afaik this should work with your plugin) and the Crowdfunding plugin. If you need more info let me know

BjornW commented 10 years ago

After looking into the AbstractPaymentData.php file it seems the error message is hitting the nail on the head: the payment_id is public in the abstract class, but made private in the extended class which seems to cause this issue. I'm hesitant in just making the payment_id public in the extended class as I cannot oversee if this may cause any unwanted side effects.

remcotolsma commented 10 years ago

Fixed in https://github.com/pronamic/wp-pronamic-ideal/commit/b820766335b595cc59c2c5d589f3233cb36a994a