search

pronebird / UIScrollView-InfiniteScroll

UIScrollView ∞ scroll category
MIT License
1.06k stars 148 forks source link

Updated for Swift 2.2, Support for Carthage #29

Closed maximveksler closed 8 years ago

pronebird commented 8 years ago

This PR looks pretty legit to me. I'll test and merge it in the morning. Thanks a lot! :+1:

pronebird commented 8 years ago

I think your issue with Carthage was related to the fact that there was no tag that would cover Carthage support that was added with #26.

Would you please mind to separate Swift 2.2 changes into different PR? Otherwise I can cherry pick them.

Also, I am certainly not able to compile it with Xcode 7.2, therefore I'll probably merge your PR into separate branch and push it to master when Xcode 7.3 is released.

Thank you for your efforts! :+1:

maximveksler commented 8 years ago

Xcode 7.3 has been released with Swift 2.2.

Can we merge this please?

pronebird commented 8 years ago

I apologize for delay. I just installed 7.3 and I cherry-picked Swift 2.2 upgrade. Everything works fine. I don't think we have to share demo app's scheme (at least based on documentation, it's main purpose is continuous integration) – https://developer.apple.com/library/ios/recipes/xcode_help-scheme_editor/Articles/SchemeShare.html

I have to close this PR since it's partially merged into master.