search

pronebird / UIScrollView-InfiniteScroll

UIScrollView ∞ scroll category
MIT License
1.06k stars 148 forks source link

Add startInfiniteScrollHandler method for UIView+InfiniteScroll #44

Closed edopelawi closed 7 years ago

pronebird commented 7 years ago

12 is relevant to this feature.

edopelawi commented 7 years ago

Thanks for reviewing my PR! I'll add the missing points and take a look on #12, then.

pronebird commented 7 years ago

Thanks again for your PR.

However, I implemented this in https://github.com/pronebird/UIScrollView-InfiniteScroll/tree/feature/begin-infinite-scroll

Please see #12 for change list. My PR is a little more comprehensive as it covers such issues as initial loading and scroll back to top, issues with self-sizing cells and scroll to bottom. Also, allows scroll to bottom when manually starting infinite scroll in both collection views and table views.

It would be great if you could test it among other people and give your feedback or report bugs. Please use device when testing because recent simulator from Xcode beta works kinda funny.

Changeset itself has been decoupled into #49

edopelawi commented 7 years ago

Hey @pronebird, apologies for the late reply.

Sure thing man, checking out your PR now! Thanks for letting me know :)

pronebird commented 7 years ago

Thanks again for your efforts. This feature has been released with 1.0.0.