Since 0.11.0 RUBOCOP_CONFIG is no longer supported

prontolabs / pronto-rubocop

Pronto runner for Rubocop, ruby code analyzer

MIT License

83 stars 74 forks source link

Since 0.11.0 RUBOCOP_CONFIG is no longer supported #67

Closed clive-devops closed 1 year ago

clive-devops commented 3 years ago

Since the 0.11.0 release setting export RUBOCOP_CONFIG=my-custom-config-path is no longer working. It works fine for Rubocop itself, but not for pronto-rubocop.

We use the same export as part of our CI and since the pronto-rubocop release 0.11.0 rubcop continues to run correctly but we're getting failures if we use pronto-rubocop.

haseebab commented 2 years ago

I'm experiencing the same issue. Looks like it was removed in this commit: https://github.com/prontolabs/pronto-rubocop/pull/44/files#diff-f8a1b8209086b10d50565dc2776339d453c4bd8783d3c1dfb28907fcad85a125L37

I'm not sure if this was by design or accident, it looks like the README still includes the use of RUBOCOP_CONFIG. I have a fix PR up: https://github.com/prontolabs/pronto-rubocop/pull/72

maxveldink commented 2 years ago

+1 for getting this fixed up. I would love to not maintain a fork for this functionality :)