prontolabs / pronto-rubocop

Pronto runner for Rubocop, ruby code analyzer
MIT License
83 stars 74 forks source link

Pronto does not raise error when removing blank line from between methods #69

Open mariusz-blaszczak opened 3 years ago

mariusz-blaszczak commented 3 years ago

I found following issue:

Steps to recreate

  1. clone repo https://github.com/mariusz-blaszczak/recreate_error_in_pronto_rubocop
  2. bundle install
  3. rubocop main.rb - raises 0 errors
  4. git checkout -b test
  5. Modify file main.rb: remove empty line between methods foo and bar
  6. rubocop main.rb - raises Use empty lines between method definitions
  7. pronto run - does not raise error

Expected

Pronto should raise error Use empty lines between method definitions

Actual

No error from pronto

Additional info

Tested with ruby 2.7.0p0

M-Yamashita01 commented 3 years ago

We tried the same procedure and the error was not detected.

Looking to Pronto, pronto run is detected error for committed changes. Because the procedure is not included the commit command for the changes, we think that the error was not detected. If we run pronto run --unstaged, the error seems to be detected.

We will be happy if we can be of any help.