search

prontolabs / pronto-rubocop

Pronto runner for Rubocop, ruby code analyzer
MIT License
83 stars 74 forks source link

Re-respect rubocop files config #85

Closed tejanium closed 1 year ago

tejanium commented 1 year ago

This PR https://github.com/prontolabs/pronto-rubocop/pull/36 basically reverts changes from this PR https://github.com/prontolabs/pronto-rubocop/pull/16 "Process files included in .rubocop.yml"

It happen because starting from https://github.com/prontolabs/pronto-rubocop/pull/36/files#diff-bd66c995e7650e0ca147e089eb3732f7a0b7bb0de38733f83e97485254285317R7 it passes down ruby_patches from Pronto's runner instead of the whole @patches, so it again ignores the files configured in .rubocop.yml. In our case, it ignores .jbuilder extensions

ashkulz commented 1 year ago

Thanks for the contribution, @tejanium! I'll make a release at the end of the week :+1: