search

prontolabs / pronto

Quick automated code review of your changes
MIT License
2.63k stars 245 forks source link

Ruby 3.0 #396

Closed dsander closed 3 years ago

dsander commented 3 years ago

With ruby 3.0 rexml is not installed by default. It was moved to a gem. Adding the gem as a dependency fixed the specs on ruby 3.0.

ashkulz commented 3 years ago

Looks like the Ruby 3.0 build is broken with Travis CI. I guess we should migrate to GitHub Actions? :thinking:

dsander commented 3 years ago

Looks like the Ruby 3.0 build is broken with Travis CI. I guess we should migrate to GitHub Actions? 🤔

Yeah this might be a good idea, I don't know if the Ruby 3.0 build can be fixed on Travis. Even if it does the build (queue) times are ridiculous at the moment.

dsander commented 3 years ago

Got it working on TravisCI and submitted a draft PR which runs CI on GitHub actions: https://github.com/prontolabs/pronto/pull/397

ashkulz commented 3 years ago

Thanks for the contribution, @dsander!