fix(Gitlab): slug_regex when url has different host

prontolabs / pronto

Quick automated code review of your changes

MIT License

2.62k stars 245 forks source link

Closed ArmandoAssuncao closed 2 years ago

ArmandoAssuncao commented 2 years ago

Sometimes the host of runner in Gitlab can be different of api_endpoint.

A example:

api_endpoint is https://gitlab.com/api/v4
runner host is https://git-us-east1-d.ci-gateway.int.gprd.gitlab.net:8989/group/x/y/z.git

the difference is in gitlab.com and gitlab.net

This PR treat when hosts are differents.

ashkulz commented 2 years ago

Thanks for the contribution, @ArmandoAssuncao! Sorry for the late review.

ashkulz commented 2 years ago

@ArmandoAssuncao can you make a change as per the rubocop failure?

lib/pronto/gitlab.rb:90 W: Style/RegexpLiteral: Use `//` around regular expression.

ArmandoAssuncao commented 2 years ago

@ashkulz fixed

ashkulz commented 2 years ago

Thanks for the contribution!