prontolabs / pronto

Quick automated code review of your changes
MIT License
2.6k stars 245 forks source link

Pronto doesn't seem to compare files if they only changed file mode #429

Open renatolond opened 2 years ago

renatolond commented 2 years ago

Hi! Thanks for your work in pronto :)

rubocop has a check for executables files without the right permission:

run:1:1: W: Lint/ScriptPermission: Script file run doesn't have execute permission.
#!/usr/bin/env ruby
^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense auto-correctable

However, if I change the file mode, it seems pronto does not run rubocop on this file:

diff --git a/run b/run
old mode 100755
new mode 100644