search

prontolabs / pronto

Quick automated code review of your changes
MIT License
2.6k stars 245 forks source link

Adds Ruby 3.2 to the CI matrix #438

Closed petergoldstein closed 1 year ago

petergoldstein commented 1 year ago

Also updates checkout action version.

The current published version of pronto is not compatible with Ruby 3.2, because of the rugged dependency. Rugged only became Ruby 3.2 compliant as of version 1.4.2 or so. If would be great to have this merged and a new gem version published.

Currently this is blocking some compatibility efforts on https://github.com/JEG2/highline , so an updated gem would definitely be appreciated.

cc: @abinoam

ashkulz commented 1 year ago

Thanks for the contribution, @petergoldstein! I was kinda waiting for #433 before releasing a new version, but you're right -- it's been a long time since a release 👍

ashkulz commented 1 year ago

I don't have the machine I normally use, will try to release over the weekend.

petergoldstein commented 1 year ago

@ashkulz Sounds good. Once that's done I can put up PRs that add Ruby 3.1 and 3.2 to CI for all the assorted pronto gems.

ashkulz commented 1 year ago

Release 0.11.1 has been pushed to RubyGems.

petergoldstein commented 1 year ago

@ashkulz Great. I've submitted PRs for everything but pronto-poper and pronto-rubocop. The former still doesn't build because poper has direct dependencies on pre-1.0 rugged. The latter has a few spec failures I need to look at.

ashkulz commented 1 year ago

@petergoldstein thanks for all the PRs, I've merged all of them 🎉

petergoldstein commented 1 year ago

@ashkulz Great. Thanks. Not exactly sure why pronto-rubocop is failing - it's failing now across all Rubies, presumably because of a change in rugged. May be worth a look from someone who is more familiar with the gem than I am.

ashkulz commented 1 year ago

@petergoldstein did you update your fork? I fixed a similar-sounding issue in prontolabs/pronto-rubocop@36c6accb5c124ae228ccd7552d7252f3378bc42f 🤔

petergoldstein commented 1 year ago

@ashkulz I hadn't caught that update. I'll rebase and see if that resolves the issue. Thanks!

petergoldstein commented 1 year ago

@ashkulz Yep, that was it. Submitted pronto-rubocop PR.

I'm not clear if poper is still maintained, as it hasn't received any updates in 3.5 years and has open, critical commits. So I'm not going to worry about pronto-poper

I think that's it for me. Thanks for merging all of these PRs.

abinoam commented 1 year ago

Dear @mmozuras,

Who has commit and release permission for Poper gem?

If possible, could add more contributors like @petergoldstein and @ashkulz?

abinoam commented 1 year ago

https://github.com/mmozuras/poper/issues/19

ashkulz commented 1 year ago

@petergoldstein, thanks for working on them -- happy new year in advance!