prontolabs / pronto

Quick automated code review of your changes
MIT License
2.6k stars 245 forks source link

Dotfiles are being ignored #444

Open KaoruDev opened 1 year ago

KaoruDev commented 1 year ago

TLDR: dotfiles are ignored in exclude option, I believe the bug is here: https://github.com/prontolabs/pronto/blob/f5feefa5cbe7ba54839ef064f5fe9b8512e92b7d/lib/pronto/config.rb#L49

and changing it to Dir.glob(path.tos, File::FNM_DOTMATCH)

According to: https://stackoverflow.com/questions/11385795/how-to-list-directory-contents-including-dotfiles-but-not-and

Steps to reproduce

I have the following structure:

.buildkite/src/
  package.json
  index.js
  .eslintrc.js
.eslintrc.json
packaage.json

And the following config:

all:
  exclude:
    - ".buildkite/**/*"

However, dotfile changes are still getting picked up by pronto.