search

prontolabs / pronto

Quick automated code review of your changes
MIT License
2.62k stars 245 forks source link

relax octokit dependency to allow releases up to 9.0 #454

Closed ashkulz closed 11 months ago

ashkulz commented 11 months ago

fixes #453

pbstriker38 commented 11 months ago

You can't allow Octokit 8.0 without fixing the argument being passed to create_pull_comment. Pronto is sending position and Octokit is sending that to the API as line. So it will either return a 422 if the position does not map to a valid line or put the comment on the wrong line.

I'm working on a fix and I'll have a PR open shortly.

ashkulz commented 11 months ago

Thanks, I was going to work on it but you beat me to it :slightly_smiling_face: