note: this is a change mostly to simplify logic that already works properly.
my understanding of paused pipelines is that they are by definition not loaded, meaning that the issue capability does not issue the DeleteAllInFolder command.
To add an extra layer of safety to this behavior, I've updated the pipeline issue functions to always return an empty array of actions for paused pipelines, so that:
people who have received tickets from the pipeline will explicitly not have their event-specific folder updated by the feed polling mechanism
and so that new users who don't have PCDs in the given folder just don't get anything.
I think this change is the final thing blocking me from being 100% comfortable with pauseing the ETH Berlin pipeline in production.
note: this is a change mostly to simplify logic that already works properly.
my understanding of
pausedpipelines is that they are by definition notloaded, meaning that theissuecapability does not issue theDeleteAllInFoldercommand.https://github.com/proofcarryingdata/zupass/blob/ivan/pause-pipelines/apps/passport-server/src/services/generic-issuance/pipelines/LemonadePipeline.ts#L825-L831
To add an extra layer of safety to this behavior, I've updated the pipeline
issuefunctions to always return an empty array ofactionsforpausedpipelines, so that:I think this change is the final thing blocking me from being 100% comfortable with
pauseing the ETH Berlin pipeline in production.